zentol commented on a change in pull request #14678: URL: https://github.com/apache/flink/pull/14678#discussion_r559859082
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/FailureListener.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.core.plugin.Plugin; +import org.apache.flink.runtime.metrics.groups.JobManagerJobMetricGroup; + +/** Failure listener to customize the behavior for each type of failures tracked in job manager. */ +public interface FailureListener extends Plugin { + + /** + * Initialize the listener with JobManagerJobMetricGroup. + * + * @param metricGroup metrics group that the listener can add customized metrics definition. + */ + void init(JobManagerJobMetricGroup metricGroup); Review comment: `JobManagerJobMetricGroup` is an internal API that should not be exposed to user-code. Use `MetricGroup` instead. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/FailureListener.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.core.plugin.Plugin; +import org.apache.flink.runtime.metrics.groups.JobManagerJobMetricGroup; + +/** Failure listener to customize the behavior for each type of failures tracked in job manager. */ +public interface FailureListener extends Plugin { + + /** + * Initialize the listener with JobManagerJobMetricGroup. + * + * @param metricGroup metrics group that the listener can add customized metrics definition. + */ + void init(JobManagerJobMetricGroup metricGroup); + + /** + * Method to handle a failure in the listener. + * + * @param cause the failure cause + * @param globalFailure whether the failure is a global failure + */ + void onFailure(final Throwable cause, boolean globalFailure); Review comment: Shouldn't this also receive some information about the job? Given that the listener is configured per cluster, how would an implementation distinguish errors between different jobs within a session cluster? I think it would be good to out-line the use-case that you're trying to accomplish; as it stands, outside of counting exceptions there's little you can do with the current interface. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/FailureListenerFactory.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.core.plugin.PluginManager; +import org.apache.flink.core.plugin.PluginUtils; +import org.apache.flink.runtime.metrics.groups.JobManagerJobMetricGroup; + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; + +/** Factory class for creating {@link FailureListener} with plugin Manager. */ +public class FailureListenerFactory { Review comment: Seems like a misnomer to call this a factory. You could replace this entire class with a static method that returns a collection of listeners. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/FailureListener.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.core.plugin.Plugin; +import org.apache.flink.runtime.metrics.groups.JobManagerJobMetricGroup; + +/** Failure listener to customize the behavior for each type of failures tracked in job manager. */ +public interface FailureListener extends Plugin { + + /** + * Initialize the listener with JobManagerJobMetricGroup. + * + * @param metricGroup metrics group that the listener can add customized metrics definition. + */ + void init(JobManagerJobMetricGroup metricGroup); + + /** + * Method to handle a failure in the listener. + * + * @param cause the failure cause + * @param globalFailure whether the failure is a global failure Review comment: This needs better documentation or additional guidance on what constitutes a global failure. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/FailureListenerFactory.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.core.plugin.PluginManager; +import org.apache.flink.core.plugin.PluginUtils; +import org.apache.flink.runtime.metrics.groups.JobManagerJobMetricGroup; + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; + +/** Factory class for creating {@link FailureListener} with plugin Manager. */ +public class FailureListenerFactory { + private final PluginManager pluginManager; + private List<FailureListener> failureListeners = new ArrayList<>(); Review comment: why is this not `final`? ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/FailureListenerFactory.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.core.plugin.PluginManager; +import org.apache.flink.core.plugin.PluginUtils; +import org.apache.flink.runtime.metrics.groups.JobManagerJobMetricGroup; + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; + +/** Factory class for creating {@link FailureListener} with plugin Manager. */ +public class FailureListenerFactory { + private final PluginManager pluginManager; Review comment: What are we keeping this reference for? ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/FailureListener.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.core.plugin.Plugin; +import org.apache.flink.runtime.metrics.groups.JobManagerJobMetricGroup; + +/** Failure listener to customize the behavior for each type of failures tracked in job manager. */ +public interface FailureListener extends Plugin { Review comment: I would recommend having a factory implement the Plugin interface. This allows implementations to be much more flexible structurally. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
