[ 
https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206614#comment-15206614
 ] 

ASF GitHub Bot commented on FLINK-3544:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r57011449
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
    @@ -60,8 +63,8 @@
         * See documentation
         */
        public static int calculateHeapSize(int memory, 
org.apache.flink.configuration.Configuration conf) {
    -           float memoryCutoffRatio = 
conf.getFloat(ConfigConstants.YARN_HEAP_CUTOFF_RATIO, 
ConfigConstants.DEFAULT_YARN_HEAP_CUTOFF_RATIO);
    -           int minCutoff = 
conf.getInteger(ConfigConstants.YARN_HEAP_CUTOFF_MIN, 
ConfigConstants.DEFAULT_YARN_MIN_HEAP_CUTOFF);
    +           float memoryCutoffRatio = 
conf.getFloat(ConfigConstants.YARN_HEAP_CUTOFF_RATIO, 0.25f);
    +           int minCutoff = 
conf.getInteger(ConfigConstants.YARN_HEAP_CUTOFF_MIN, 600);
    --- End diff --
    
    I was actually referring to why not using 
`ConfigConstants.DEFAULT_YARN_HEAP_CUTOFF` instead of `600`?


> ResourceManager runtime components
> ----------------------------------
>
>                 Key: FLINK-3544
>                 URL: https://issues.apache.org/jira/browse/FLINK-3544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to