xintongsong commented on a change in pull request #14591:
URL: https://github.com/apache/flink/pull/14591#discussion_r564142313
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager
respectively.");
+ public static final ConfigOption<List<Map<String, String>>>
JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to
the JobManager Deployment. "
+ + "The owner reference is used to delete
deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of
key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
Hi @blublinsky,
You don't need to explain to me, because I'm quite familiar with how these
things work for Flink and Kubernetes.
What I meant in the previous comment is that, these things should also be
explained in the description of the config option, so that users who may not be
as familiar with Flink and Kubernetes as us won't get confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
