[ https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207298#comment-15207298 ]
ASF GitHub Bot commented on FLINK-3639: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1827#discussion_r57068281 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/RegisterDataSetITCase.scala --- @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.scala.table.test + +import org.apache.flink.api.scala._ +import org.apache.flink.api.scala.table._ +import org.apache.flink.api.scala.util.CollectionDataSets +import org.apache.flink.api.table.{TableException, Row} +import org.apache.flink.api.table.plan.TranslationContext +import org.apache.flink.api.table.test.utils.TableProgramsTestBase +import org.apache.flink.api.table.test.utils.TableProgramsTestBase.TableConfigMode +import org.apache.flink.test.util.MultipleProgramsTestBase.TestExecutionMode +import org.apache.flink.test.util.TestBaseUtils +import org.junit._ +import org.junit.runner.RunWith +import org.junit.runners.Parameterized + +import scala.collection.JavaConverters._ + +@RunWith(classOf[Parameterized]) +class RegisterDataSetITCase( --- End diff -- If we move the common methods of the Java and Scala `TableEnvironment`s to an `AbstractTableEnvironment`, it is sufficient to only have the Scala tests, IMO. > Add methods and utilities to register DataSets and Tables in the > TableEnvironment > --------------------------------------------------------------------------------- > > Key: FLINK-3639 > URL: https://issues.apache.org/jira/browse/FLINK-3639 > Project: Flink > Issue Type: New Feature > Components: Table API > Affects Versions: 1.1.0 > Reporter: Vasia Kalavri > Assignee: Vasia Kalavri > > In order to make tables queryable from SQL we need to register them under a > unique name in the TableEnvironment. > [This design > document|https://docs.google.com/document/d/1sITIShmJMGegzAjGqFuwiN_iw1urwykKsLiacokxSw0/edit] > describes the proposed API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)