rmetzger commented on a change in pull request #63:
URL: https://github.com/apache/flink-docker/pull/63#discussion_r565311288
##########
File path: add-version.sh
##########
@@ -112,9 +112,9 @@ for source_variant in "${SOURCE_VARIANTS[@]}"; do
flink_url_file_path=flink/flink-${flink_version}/flink-${flink_version}-bin-scala_${scala_version}.tgz
-
flink_tgz_url="https://www.apache.org/dyn/closer.cgi?action=download&filename=${flink_url_file_path}";
+
flink_tgz_url="https://archive.apache.org/dist/${flink_url_file_path}";
Review comment:
The only note I found about this, is on this page:
http://archive.apache.org/, and it states
> Do note that a daily limit of 5GB per IP is being enforced on
archive.apache.org, to prevent abuse.
Even though our e2e tests are downloading from archive.apache.org regularly
already, we don't seem to run into any limits:
```
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/main/java/org/apache/flink/tests/util/kafka/LocalStandaloneKafkaResource.java:
"https://archive.apache.org/dist/kafka/%s/kafka_2.11-%s.tgz";,
flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/LocalStandaloneHBaseResource.java:
"https://archive.apache.org/dist/hbase/%1$s/hbase-%1$s-bin.tar.gz";,
hbaseVersion);
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile:ENV
HADOOP_URL
http://archive.apache.org/dist/hadoop/common/hadoop-$HADOOP_VERSION/hadoop-$HADOOP_VERSION.tar.gz
flink-end-to-end-tests/test-scripts/kafka-common.sh:
KAFKA_URL="https://archive.apache.org/dist/kafka/$KAFKA_VERSION/kafka_2.12-$KAFKA_VERSION.tgz";
```
Dockerfiles generated from this script will be build during e2e tests, and
once by DockerHub when we do a new release. I believe this is an acceptable
download frequency.
I'm happy to adjust this if we run into limits with archive.a.o, but for now
I don't think it's worth our time overoptimizing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
