[
https://issues.apache.org/jira/browse/FLINK-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208200#comment-15208200
]
ASF GitHub Bot commented on FLINK-2444:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1628#discussion_r57137864
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopInputFormatTest.java
---
@@ -20,22 +20,137 @@
import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.hadoop.mapreduce.wrapper.HadoopInputSplit;
import org.apache.flink.api.java.tuple.Tuple2;
import org.apache.flink.api.java.typeutils.TupleTypeInfo;
-import org.apache.flink.api.java.hadoop.mapreduce.HadoopInputFormat;
-import org.apache.hadoop.mapreduce.InputSplit;
-import org.apache.hadoop.mapreduce.Job;
-import org.apache.hadoop.mapreduce.RecordReader;
-import org.apache.hadoop.mapreduce.TaskAttemptContext;
+import org.apache.hadoop.conf.Configurable;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.mapreduce.*;
--- End diff --
No star imports please.
> Add tests for HadoopInputFormats
> --------------------------------
>
> Key: FLINK-2444
> URL: https://issues.apache.org/jira/browse/FLINK-2444
> Project: Flink
> Issue Type: Test
> Components: Hadoop Compatibility, Tests
> Affects Versions: 0.9.0, 0.10.0
> Reporter: Fabian Hueske
> Assignee: Martin Liesenberg
> Labels: starter
>
> The HadoopInputFormats and HadoopInputFormatBase classes are not sufficiently
> covered by unit tests.
> We need tests that ensure that the methods of the wrapped Hadoop InputFormats
> are correctly called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
