gaoyunhaii commented on a change in pull request #14734:
URL: https://github.com/apache/flink/pull/14734#discussion_r567764140
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -563,7 +554,7 @@ private void
startTriggeringCheckpoint(CheckpointTriggerRequest request) {
createPendingCheckpoint(
timestamp,
request.props,
- ackTasks,
+ checkpointBrief,
Review comment:
Very thanks @guoweiM for the thoughts! For me I'm more tend to make
function parameters more "specific" and only use the composite object if we
relies on multiple properties of it. But I'm also open to other options. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
