wuchong commented on a change in pull request #14813:
URL: https://github.com/apache/flink/pull/14813#discussion_r567807783
##########
File path:
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java
##########
@@ -299,6 +299,27 @@ public void testSerializeDeserializeNestedTypes() throws
Exception {
testSerDeConsistency(nullRow, serSchemaBuilder, deserSchemaBuilder);
}
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testDeserializationWithDisableQuoteCharacter() throws
Exception {
Review comment:
We can simplify the test into following to reuse the logic of
constructing schema and rows.
```scala
@Test
public void testDeserializationWithQuoteCharacterDisabled() throws
Exception {
Consumer<CsvRowDataDeserializationSchema.Builder> deserConfig =
(deserSchemaBuilder) ->
deserSchemaBuilder
.setEscapeCharacter('*')
.disableQuoteCharacter()
.setArrayElementDelimiter(":")
.setFieldDelimiter(';');
testFieldDeserialization(STRING(), "\"abc", "\"abc", deserConfig,
";");
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
