amaliujia commented on a change in pull request #14791:
URL: https://github.com/apache/flink/pull/14791#discussion_r569191629
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalPythonGroupWindowAggregateRule.java
##########
@@ -78,11 +78,11 @@ public boolean matches(RelOptRuleCall call) {
.anyMatch(x -> PythonUtil.isPythonAggregate(x,
PythonFunctionKind.PANDAS));
boolean existJavaFunction =
aggCalls.stream().anyMatch(x ->
!PythonUtil.isPythonAggregate(x, null));
+ if (existPandasFunction && existGeneralPythonFunction) {
+ throw new TableException(
Review comment:
Also this might be your design decision before: why throw a exception
than return false to indicate this rule does not match the case when both
general python function and pandas functions appear together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
