XComp commented on a change in pull request #14798:
URL: https://github.com/apache/flink/pull/14798#discussion_r569551171
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -317,13 +316,11 @@ public TaskManagerLocation getAssignedResourceLocation() {
: null;
}
- public Throwable getFailureCause() {
- return failureCause;
- }
-
@Override
- public String getFailureCauseAsString() {
- return ExceptionUtils.stringifyException(getFailureCause());
+ public Optional<ErrorInfo> getFailureInfo() {
+ return failureCause == null
+ ? Optional.empty()
+ : Optional.of(new ErrorInfo(failureCause,
getStateTimestamp(FAILED)));
Review comment:
Yes, it does. I actually had it like that in a first version of the code
but changed it for the sake of consistency after realizing that it's not
Serializable (which was a problem in `ArchivedExecution`). I will revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
