gaoyunhaii commented on pull request #14754: URL: https://github.com/apache/flink/pull/14754#issuecomment-774955426
Hi Roman @rkhachatryan, very thanks for the review! I addressed the comments and added the missing test in https://github.com/apache/flink/pull/14754/commits/0f8924698701b1d6768f8757414d69836b83fa3a. The usage of the `fullyFinished` flag is indeed not include in this PR. The flag is expected to be passed to the task after recovery in [FLINK-21088](https://issues.apache.org/jira/browse/FLINK-21088), and used to skip the execution of the fully finished operator in [FLINK-21089](https://issues.apache.org/jira/browse/FLINK-21089). In detail, it would make the fully finished source directly send EndOfPartitionEvent to finish the channel, and skip lifecycle methods like `open`/`close` for the fully finished operators. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
