wangyang0918 edited a comment on pull request #14837: URL: https://github.com/apache/flink/pull/14837#issuecomment-774945693
@tillrohrmann Thanks for your nice review of this PR. I force pushed again and please have a look. I think now I realized what is problem of this PR or some my previous PRs. Taking a shortcut(e.g. not closing the watch and let it destroyed with process died, using the fabric8 internal implementation details to save codes) is not a good habit. It could work, but not very easy to understand for other devs. I will try to get this improved in the future PRs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
