lgo commented on pull request #12345: URL: https://github.com/apache/flink/pull/12345#issuecomment-775169629
It passes all of the tests in `flink-statebackend-rocksdb` module. I have not done any other testing, like setitng up an app and experimenting. I added all the code behind a configuration option so both paths can continue to be executed. To test them both, I parameterized RocksDB tests to test both the WriteBatchWrapper (current) and SstFileWriter (new) ways of writing bulk `put` operations, and for a few tests duplicated them to trigger both paths. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
