xintongsong edited a comment on pull request #14904: URL: https://github.com/apache/flink/pull/14904#issuecomment-775776799
cc @tillrohrmann Could you please take a look at this PR? One thing I'm not entirely sure is that, do we still need a configuration option to fallback to the original behaviors, given that we have already forbidden wrapping buffers from unsafe segments? This [branch](https://github.com/xintongsong/flink/tree/FLINK-20663-managed-memory-2) contains an additional commit compared to this PR, which introduces such a configuration option by touching quite some files. (FYI, this branch also passed the [CI tests](https://dev.azure.com/tonysong820/Flink/_build/results?buildId=154&view=results).) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org