[
https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282253#comment-17282253
]
Kezhu Wang commented on FLINK-21133:
------------------------------------
Hi all, there are actually two cases for FLIP-27 sources not working with
stop-with-savepoint:
# {{SourceOperatorStreamTask}} does not finish itself on {{finishTask}}.
# {{MultipleInputStreamTask}} does not finish itself if it is the heading task
that triggering checkpoint.
Fix to first case is simple. Fix to second case may require extra works, such
as moving {{finishTask}} to path {{triggerCheckpointAsync}}, I am unsure of
this.
I pushed another [branch with two test
cases|https://github.com/kezhuw/flink/commit/3578b67d6d880d7981bc8b3c0d425eb9f57caaf7],
{{testStopSavepointWithFlip27SourceChainedOut}} still fail after
{{SourceOperatorStreamTask.finishTask}} introduced.
I am wonder whether we could separate the two so the first could be fixed
without blocking on the second. The second need extra attention from
stop-with-savepoint path.
I could provide a fix for first case if there is no one working on it yet.
[~trohrmann] [~pnowojski] [~jqin], [~aljoscha]
> FLIP-27 Source does not work with synchronous savepoint
> -------------------------------------------------------
>
> Key: FLINK-21133
> URL: https://issues.apache.org/jira/browse/FLINK-21133
> Project: Flink
> Issue Type: Bug
> Components: API / Core, API / DataStream, Runtime / Checkpointing
> Affects Versions: 1.11.3, 1.12.1
> Reporter: Kezhu Wang
> Priority: Critical
> Fix For: 1.11.4, 1.12.2, 1.13.0
>
>
> I have pushed branch
> [synchronous-savepoint-conflict-with-bounded-end-input-case|https://github.com/kezhuw/flink/commits/synchronous-savepoint-conflict-with-bounded-end-input-case]
> in my repository. {{SavepointITCase.testStopSavepointWithFlip27Source}}
> failed due to timeout.
> See also FLINK-21132 and
> [apache/iceberg#2033|https://github.com/apache/iceberg/issues/2033]..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
