zentol commented on a change in pull request #14921:
URL: https://github.com/apache/flink/pull/14921#discussion_r574374822
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/StateWithExecutionGraph.java
##########
@@ -106,14 +107,17 @@
context.getMainThreadExecutor()));
}
+ @VisibleForTesting
Review comment:
Since the scheduler should not be able to access them I assumed this was
done for testing purposes.
If they were simply made accessible to sub-classes, then they should be made
protected to convey this.
(With the exception of getExecutionGraph which actually needs this to be
package-private)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
