XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r574569882
########## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java ########## @@ -600,6 +616,171 @@ public void testSubmitWithUnknownSavepointPath() throws Exception { } } + @Test + public void testStopWithSavepointFailingInSnapshotCreation() throws Exception { + testStopWithFailingSourceInOnePipeline( + new SnapshotFailingInfiniteTestSource(), + folder.newFolder(), + // two restarts expected: + // 1. task failure restart + // 2. job failover triggered by the CheckpointFailureManager + 2, + assertInSnapshotCreationFailure()); + } + + @Test + public void testStopWithSavepointFailingAfterSnapshotCreation() throws Exception { Review comment: This is fixed after letting the error handling run in the `mainThreadExecutor` again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org