kezhuw opened a new pull request #14936:
URL: https://github.com/apache/flink/pull/14936
## What is the purpose of the change
Dropping nullable-value support from `SerializedValue` to simplify its
usages. Callers should resort to nullabe/optional variable of `SerializedValue`
if them want such behavior but just can't treat `SerializedValue` as another
optional container anymore.
## Brief change log
- Migrate usage of `SerializedValue` in rpc module to its own wire value
class. This make this module self-contained and resistant to rpc usages of
`SerializedValue`.
- Dropping nullable-value support from `SerializedValue`.
## Verifying this change
This change is already covered by existing tests, such as *(please describe
tests)*.
* `SerializedValueTest.testSimpleValue`.
This change added tests and can be verified as follows:
- `SerializedValueTest.testNullValue`,
`SerializedValueTest.testFromNullBytes`,
`SerializedValueTest.testFromEmptyBytes`
- `AkkaRpcSerializedValueTest`
- `AkkaRpcActorTest.canRespondWithSerializedValueLocally`,
`RemoteAkkaRpcActorTest.canRespondWithSerializedValueRemotely`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (don't know)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
## WARNING
**This change will breaking tm/jm rolling update if we ever support it.** I
got nothing of such supporting from docs and assume no such guarantee.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
