zentol commented on a change in pull request #14928:
URL: https://github.com/apache/flink/pull/14928#discussion_r576252689



##########
File path: 
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -392,6 +394,25 @@
                     .withDescription(
                             "Configure the minimum increase in parallelism for 
a job to scale up.");
 
+    @Documentation.Section({
+        Documentation.Sections.EXPERT_SCHEDULING,
+        Documentation.Sections.ALL_JOB_MANAGER
+    })
+    public static final ConfigOption<Duration> RESOURCE_WAIT_TIMEOUT =
+            key("jobmanager.declarative-scheduler.resource-wait-timeout")
+                    .durationType()
+                    .defaultValue(Duration.ofSeconds(10))

Review comment:
       For now I intend to set these explicitly in the e2e tests, and would 
wait with increasing the defaults once we gathered more data.
   
   Overall, my impression for the e2e tests is that we should provide a way to 
disabling the downScaling, in cases where you absolutely need to run a job with 
a certain parallelism. (which the e2e do, as well as some unit tests)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to