[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220521#comment-15220521
]
ASF GitHub Bot commented on FLINK-3034:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r58112927
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisCommandsContainerBuilder.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.streaming.connectors.redis.common.container;
+
+import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
+import
org.apache.flink.streaming.connectors.redis.common.config.JedisClusterConfig;
+import
org.apache.flink.streaming.connectors.redis.common.config.JedisPoolConfig;
+import
org.apache.flink.streaming.connectors.redis.common.config.JedisSentinelConfig;
+import redis.clients.jedis.JedisCluster;
+import redis.clients.jedis.JedisPool;
+import redis.clients.jedis.JedisSentinelPool;
+
+public class RedisCommandsContainerBuilder {
+
+ /**
+ * Builds container for single Redis environment.
+ * @param jedisPoolConfig configuration for JedisPool
+ * @return container for single Redis environment
+ */
+ public static RedisCommandsContainer build(JedisPoolConfig
jedisPoolConfig) {
+ GenericObjectPoolConfig genericObjectPoolConfig = new
GenericObjectPoolConfig();
+
genericObjectPoolConfig.setMaxIdle(jedisPoolConfig.getMaxIdle());
+
genericObjectPoolConfig.setMaxTotal(jedisPoolConfig.getMaxTotal());
+
genericObjectPoolConfig.setMinIdle(jedisPoolConfig.getMinIdle());
+
+ JedisPool jedisPool = new JedisPool(genericObjectPoolConfig,
jedisPoolConfig.getHost(),
+ jedisPoolConfig.getPort(),
jedisPoolConfig.getTimeout(), jedisPoolConfig.getPassword(),
+ jedisPoolConfig.getDatabase());
+ return new RedisContainer(jedisPool);
+ }
+
+ /**
+ * Builds container for Redis Cluster environment.
+ * @param config configuration for JedisCluster
+ * @return container for Redis Cluster environment
+ */
+ public static RedisCommandsContainer build(JedisClusterConfig config) {
+ GenericObjectPoolConfig genericObjectPoolConfig = new
GenericObjectPoolConfig();
+ genericObjectPoolConfig.setMaxIdle(config.getMaxIdle());
+ genericObjectPoolConfig.setMaxTotal(config.getMaxTotal());
+ genericObjectPoolConfig.setMinIdle(config.getMinIdle());
+
+ JedisCluster jedisCluster = new JedisCluster(config.getNodes(),
config.getTimeout(),
+ config.getMaxRedirections(), genericObjectPoolConfig);
+ return new RedisClusterContainer(jedisCluster);
+ }
+
+ /**
+ * Builds container for Redis Sentinel environment.
+ * @param config configuration for JedisSentinel
+ * @return container for Redis sentinel environment
+ */
+ public static RedisCommandsContainer build(JedisSentinelConfig config) {
--- End diff --
Check for `null`
> Redis SInk Connector
> --------------------
>
> Key: FLINK-3034
> URL: https://issues.apache.org/jira/browse/FLINK-3034
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Matthias J. Sax
> Assignee: Subhankar Biswas
> Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
