KarmaGYZ commented on a change in pull request #14954:
URL: https://github.com/apache/flink/pull/14954#discussion_r578169836
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManagerFactory.java
##########
@@ -56,6 +59,33 @@ protected Configuration
getEffectiveConfigurationForResourceManagerAndRuntimeSer
configuration, TaskManagerOptions.TOTAL_PROCESS_MEMORY);
}
+ @Override
+ protected Configuration getEffectiveConfigurationForResourceManager(
Review comment:
We can add a test for it to verify:
- If the fine-grained resource management is enabled, those options should
be removed.
- If the fine-grained resource management is not enabled, those options
should be passed by.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
