tillrohrmann commented on a change in pull request #14951:
URL: https://github.com/apache/flink/pull/14951#discussion_r578441952
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java
##########
@@ -335,9 +352,16 @@ public static ArchivedExecutionGraph
createFrom(ExecutionGraph executionGraph) {
final long[] timestamps = new long[JobStatus.values().length];
+ // if the state is overridden with a non-globally-terminal state then
we need to erase
+ // traces of globally-terminal states
+ final boolean clearGloballyTerminalStateTimestamps =
+ statusOverride != null &&
!statusOverride.isGloballyTerminalState();
Review comment:
I think we check in the beginning of this method whether
`statusOverride` is not a globally terminal state if it is not `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
