XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578582587
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointContextTest.java ########## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler; + +import org.apache.flink.api.common.time.Deadline; +import org.apache.flink.core.testutils.FlinkMatchers; +import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutorServiceAdapter; +import org.apache.flink.runtime.concurrent.ManuallyTriggeredScheduledExecutor; +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.executiongraph.Execution; +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; +import org.apache.flink.runtime.executiongraph.ExecutionVertex; +import org.apache.flink.runtime.executiongraph.failover.flip1.TestRestartBackoffTimeStrategy; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.jobgraph.JobVertex; +import org.apache.flink.runtime.taskmanager.TaskExecutionState; +import org.apache.flink.runtime.testtasks.NoOpInvokable; +import org.apache.flink.runtime.testutils.CommonTestUtils; +import org.apache.flink.runtime.testutils.DirectScheduledExecutorService; +import org.apache.flink.util.ExceptionUtils; +import org.apache.flink.util.FlinkException; +import org.apache.flink.util.TestLogger; + +import org.apache.flink.shaded.guava18.com.google.common.collect.Sets; + +import org.junit.Before; +import org.junit.Test; + +import java.time.Duration; +import java.util.Collections; +import java.util.Optional; +import java.util.function.Consumer; +import java.util.stream.Collectors; +import java.util.stream.StreamSupport; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertThat; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + +/** + * {@code StopWithSavepointContextTest} tests the stop-with-savepoint functionality of {@link + * SchedulerBase#stopWithSavepoint(String, boolean)}. + */ +public class StopWithSavepointContextTest extends TestLogger { + + private JobGraph jobGraph; + private DefaultScheduler scheduler; + + private StopWithSavepointOperations testInstance; + + @Before + public void setup() throws Exception { + jobGraph = new JobGraph(); + + final JobVertex jobVertex = new JobVertex("vertex #0"); + jobVertex.setInvokableClass(NoOpInvokable.class); + jobGraph.addVertex(jobVertex); + + // checkpointInterval has to be set to a value lower than Long.MAX_VALUE to enable + // periodic checkpointing - only then can we enable/disable the CheckpointCoordinator + SchedulerTestingUtils.enablePeriodicCheckpointing(jobGraph, Long.MAX_VALUE - 1); + scheduler = + SchedulerTestingUtils.createSchedulerBuilder( + jobGraph, ComponentMainThreadExecutorServiceAdapter.forMainThread()) + .setFutureExecutor(new DirectScheduledExecutorService()) + .build(); + scheduler.startScheduling(); + + // the checkpoint scheduler is stopped before triggering the stop-with-savepoint + disableCheckpointScheduler(); + + testInstance = new StopWithSavepointContext(jobGraph.getJobID(), scheduler, this.log); Review comment: You're right. I refactored the `StopWithSavepointContextTest`. It uses `TestingSchedulerNG` now instead of `DefaultScheduler` which removes some complexity from the test code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
