zentol commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578977899
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/StateTrackingMockExecutionGraph.java ########## @@ -0,0 +1,459 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.declarative; + +import org.apache.flink.api.common.ArchivedExecutionConfig; +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.JobID; +import org.apache.flink.api.common.JobStatus; +import org.apache.flink.api.common.accumulators.Accumulator; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.JobException; +import org.apache.flink.runtime.accumulators.AccumulatorSnapshot; +import org.apache.flink.runtime.accumulators.StringifiedAccumulatorResult; +import org.apache.flink.runtime.blob.BlobWriter; +import org.apache.flink.runtime.blob.PermanentBlobKey; +import org.apache.flink.runtime.checkpoint.CheckpointCoordinator; +import org.apache.flink.runtime.checkpoint.CheckpointIDCounter; +import org.apache.flink.runtime.checkpoint.CheckpointStatsSnapshot; +import org.apache.flink.runtime.checkpoint.CheckpointStatsTracker; +import org.apache.flink.runtime.checkpoint.CheckpointsCleaner; +import org.apache.flink.runtime.checkpoint.CompletedCheckpointStore; +import org.apache.flink.runtime.checkpoint.MasterTriggerRestoreHook; +import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor; +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.executiongraph.ErrorInfo; +import org.apache.flink.runtime.executiongraph.Execution; +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; +import org.apache.flink.runtime.executiongraph.ExecutionDeploymentListener; +import org.apache.flink.runtime.executiongraph.ExecutionGraph; +import org.apache.flink.runtime.executiongraph.ExecutionJobVertex; +import org.apache.flink.runtime.executiongraph.ExecutionVertex; +import org.apache.flink.runtime.executiongraph.IntermediateResult; +import org.apache.flink.runtime.executiongraph.JobInformation; +import org.apache.flink.runtime.executiongraph.JobStatusListener; +import org.apache.flink.runtime.executiongraph.TaskExecutionStateTransition; +import org.apache.flink.runtime.executiongraph.failover.flip1.ResultPartitionAvailabilityChecker; +import org.apache.flink.runtime.executiongraph.failover.flip1.partitionrelease.PartitionReleaseStrategy; +import org.apache.flink.runtime.io.network.partition.JobMasterPartitionTracker; +import org.apache.flink.runtime.io.network.partition.ResultPartitionID; +import org.apache.flink.runtime.jobgraph.IntermediateDataSetID; +import org.apache.flink.runtime.jobgraph.JobVertex; +import org.apache.flink.runtime.jobgraph.JobVertexID; +import org.apache.flink.runtime.jobgraph.ScheduleMode; +import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration; +import org.apache.flink.runtime.query.KvStateLocationRegistry; +import org.apache.flink.runtime.scheduler.InternalFailuresListener; +import org.apache.flink.runtime.scheduler.strategy.SchedulingTopology; +import org.apache.flink.runtime.shuffle.ShuffleMaster; +import org.apache.flink.runtime.state.CheckpointStorage; +import org.apache.flink.runtime.state.StateBackend; +import org.apache.flink.types.Either; +import org.apache.flink.util.OptionalFailure; +import org.apache.flink.util.SerializedValue; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; + +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.Executor; +import java.util.concurrent.ForkJoinPool; + +/** + * Mocked ExecutionGraph which (partially) tracks the job status, and provides some basic mocks to + * create an {@link org.apache.flink.runtime.executiongraph.ArchivedExecutionGraph} from this + * ExecutionGraph. + */ +class StateTrackingMockExecutionGraph implements ExecutionGraph { + private JobStatus state = JobStatus.INITIALIZING; + private final CompletableFuture<JobStatus> terminationFuture = new CompletableFuture<>(); + private final JobID jobId = new JobID(); + private final ArchivedExecutionConfig archivedExecutionConfig = new ExecutionConfig().archive(); + + // ---- methods to control the mock + + void completeTerminationFuture(JobStatus finalStatus) { + terminationFuture.complete(finalStatus); + state = finalStatus; + } + + // ---- interface implementations + + @Override + public boolean updateState(TaskExecutionStateTransition state) { + return true; + } + + @Override + public JobStatus getState() { + return state; + } + + @Override + public CompletableFuture<JobStatus> getTerminationFuture() { + return terminationFuture; + } + + @Override + public Executor getFutureExecutor() { + return ForkJoinPool.commonPool(); + } + + @Override + public void registerExecution(Execution exec) { + // no-op + } + + @Override + public void cancel() { + state = JobStatus.CANCELLING; + } + + @Override + public void failJob(Throwable cause) { + state = JobStatus.FAILING; + } + + @Override + public void suspend(Throwable suspensionCause) { + state = JobStatus.SUSPENDED; + } + + @Override + public void transitionToRunning() { + state = JobStatus.RUNNING; + } + + // --- interface implementations: methods for creating an archived execution graph + + @Override + public int getTotalNumberOfVertices() { + return 0; + } + + @Override + public Iterable<ExecutionJobVertex> getVerticesTopologically() { + return Collections.emptyList(); + } + + @Override + public Map<JobVertexID, ExecutionJobVertex> getAllVertices() { + return Collections.emptyMap(); + } + + @Override + public Map<String, SerializedValue<OptionalFailure<Object>>> getAccumulatorsSerialized() { + return Collections.emptyMap(); + } + + @Override + public long getStatusTimestamp(JobStatus status) { + return 0L; + } + + @Override + public String getJsonPlan() { + return ""; + } + + @Override + public JobID getJobID() { + return jobId; + } + + @Override + public String getJobName() { + return "testJob"; + } + + @Nullable + @Override + public ErrorInfo getFailureInfo() { + return null; + } + + @Nullable + @Override + public ArchivedExecutionConfig getArchivedExecutionConfig() { + return archivedExecutionConfig; + } + + @Override + public boolean isStoppable() { + return false; + } + + @Nullable + @Override + public CheckpointCoordinatorConfiguration getCheckpointCoordinatorConfiguration() { + return null; + } + + @Nullable + @Override + public CheckpointStatsSnapshot getCheckpointStatsSnapshot() { + return null; + } + + @Override + public Optional<String> getStateBackendName() { + return Optional.empty(); + } + + @Override + public Optional<String> getCheckpointStorageName() { + return Optional.empty(); + } + + @Override + public StringifiedAccumulatorResult[] getAccumulatorResultsStringified() { + return new StringifiedAccumulatorResult[0]; + } + + // -- remaining interface implementations: all unsupported + + @Override + public boolean isArchived() { + throw new UnsupportedOperationException(); + } + + @Override + public void start(@Nonnull ComponentMainThreadExecutor jobMasterMainThreadExecutor) { + throw new UnsupportedOperationException(); + } + + @Override + public int getNumberOfExecutionJobVertices() { + throw new UnsupportedOperationException(); + } + + @Override + public SchedulingTopology getSchedulingTopology() { + throw new UnsupportedOperationException(); + } + + @Override + public ScheduleMode getScheduleMode() { + throw new UnsupportedOperationException(); + } + + @Nonnull + @Override + public ComponentMainThreadExecutor getJobMasterMainThreadExecutor() { + throw new UnsupportedOperationException(); + } + + @Override + public void enableCheckpointing( + CheckpointCoordinatorConfiguration chkConfig, + List<MasterTriggerRestoreHook<?>> masterHooks, + CheckpointIDCounter checkpointIDCounter, + CompletedCheckpointStore checkpointStore, + StateBackend checkpointStateBackend, + CheckpointStorage checkpointStorage, + CheckpointStatsTracker statsTracker, + CheckpointsCleaner checkpointsCleaner) { + throw new UnsupportedOperationException(); + } + + @Nullable + @Override + public CheckpointCoordinator getCheckpointCoordinator() { + throw new UnsupportedOperationException(); + } + + @Override + public KvStateLocationRegistry getKvStateLocationRegistry() { + throw new UnsupportedOperationException(); + } + + @Override + public void setJsonPlan(String jsonPlan) { + throw new UnsupportedOperationException(); + } + + @Override + public Either<SerializedValue<JobInformation>, PermanentBlobKey> getJobInformationOrBlobKey() { + throw new UnsupportedOperationException(); + } + + @Override + public Configuration getJobConfiguration() { + throw new UnsupportedOperationException(); + } + + @Override + public ClassLoader getUserClassLoader() { + throw new UnsupportedOperationException(); + } + + @Override + public Throwable getFailureCause() { + throw new UnsupportedOperationException(); + } + + @Override + public Iterable<ExecutionVertex> getAllExecutionVertices() { + throw new UnsupportedOperationException(); + } + + @Override + public ExecutionJobVertex getJobVertex(JobVertexID id) { + throw new UnsupportedOperationException(); + } + + @Override + public long getNumberOfRestarts() { + throw new UnsupportedOperationException(); + } + + @Override + public Map<IntermediateDataSetID, IntermediateResult> getAllIntermediateResults() { + throw new UnsupportedOperationException(); + } + + @Override + public BlobWriter getBlobWriter() { + throw new UnsupportedOperationException(); + } + + @Override + public Map<String, OptionalFailure<Accumulator<?, ?>>> aggregateUserAccumulators() { + throw new UnsupportedOperationException(); + } + + @Override + public void setInternalTaskFailuresListener( + InternalFailuresListener internalTaskFailuresListener) { + throw new UnsupportedOperationException(); + } + + @Override + public void attachJobGraph(List<JobVertex> topologiallySorted) throws JobException { + throw new UnsupportedOperationException(); + } + + @Override + public void failGlobal(Throwable t) { + throw new UnsupportedOperationException(); + } + + @Override + public JobStatus waitUntilTerminal() throws InterruptedException { + throw new UnsupportedOperationException(); + } + + @Override + public boolean transitionState(JobStatus current, JobStatus newState) { + throw new UnsupportedOperationException(); + } + + @Override + public void incrementRestarts() { + throw new UnsupportedOperationException(); + } + + @Override + public void initFailureCause(Throwable t) { + throw new UnsupportedOperationException(); + } + + @Override + public void vertexFinished() { + throw new UnsupportedOperationException(); + } + + @Override + public void vertexUnFinished() { + throw new UnsupportedOperationException(); + } + + @Override + public void notifyPartitionDataAvailable(ResultPartitionID partitionId) { + throw new UnsupportedOperationException(); + } + + @Override + public Map<ExecutionAttemptID, Execution> getRegisteredExecutions() { + throw new UnsupportedOperationException(); + } + + @Override + public void updateAccumulators(AccumulatorSnapshot accumulatorSnapshot) { + throw new UnsupportedOperationException(); + } + + @Override + public void registerJobStatusListener(JobStatusListener listener) { + throw new UnsupportedOperationException(); + } + + @Override + public void assertRunningInJobMasterMainThread() { + throw new UnsupportedOperationException(); + } + + @Override + public void notifySchedulerNgAboutInternalTaskFailure( + ExecutionAttemptID attemptId, + Throwable t, + boolean cancelTask, + boolean releasePartitions) { + throw new UnsupportedOperationException(); + } + + @Override + public ShuffleMaster<?> getShuffleMaster() { + throw new UnsupportedOperationException(); + } + + @Override + public JobMasterPartitionTracker getPartitionTracker() { + throw new UnsupportedOperationException(); + } + + @Override + public ResultPartitionAvailabilityChecker getResultPartitionAvailabilityChecker() { + throw new UnsupportedOperationException(); + } + + @Override + public PartitionReleaseStrategy getPartitionReleaseStrategy() { + throw new UnsupportedOperationException(); + } + + @Override + public ExecutionDeploymentListener getExecutionDeploymentListener() { + throw new UnsupportedOperationException(); + } + + @Override + public void deregisterExecution(Execution exec) { + throw new UnsupportedOperationException(); + } + + @Override + public void notifyExecutionChange(Execution execution, ExecutionState newExecutionState) { + throw new UnsupportedOperationException(); Review comment: given that updateTaskExecutionState is a safe operation, I'd say this one should be too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
