tillrohrmann commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r579108739
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ########## @@ -635,6 +641,33 @@ public void cancel() { return executionGraph.getTerminationFuture().thenApply(FunctionUtils.nullFn()); } + protected void archiveGlobalFailure(Throwable failure) { + taskFailureHistory.add( + new ErrorInfo(failure, executionGraph.getStatusTimestamp(JobStatus.FAILED))); + log.debug("Archive global failure.", failure); + } + + protected void archiveFromFailureHandlingResult(FailureHandlingResult failureHandlingResult) { + Optional<Execution> executionOptional = + failureHandlingResult + .getExecutionVertexIdOfFailedTask() + .map(this::getExecutionVertex) + .map(ExecutionVertex::getCurrentExecutionAttempt); + + executionOptional.ifPresent( + execution -> + execution + .getFailureInfo() + .ifPresent( + failureInfo -> { + taskFailureHistory.add(failureInfo); + log.debug( + "Archive local failure causing attempt {} to fail: {}", + execution.getAttemptId(), + failureInfo.getExceptionAsString()); + })); Review comment: So theoretically we would have to add the timestamp to the `FailureHandlingResult` or the `ErrorInfo` if we didn't want to look up the `Execution` again, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org