rkhachatryan commented on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-782255709
Thanks for the review @pnowojski, I've addressed all your comments. > What's the problem with the original suggestion to just ignore savepoints? My main concern was that subtracting savepoint count from total count would keep savepoints in the queue forever. Besides that, we'd have to maintain a seperatae counter. We'd have to update it in all tree implementations. We'd have to count savepoints on restore. So I don't think it would be much more simple in the end. I also considered a third option to not enter the loop at all if we are adding a savepoint. That would be indeed simple, but: - with checkpointing disabled this could lead to the same problem (keeping savepoints forever) - the invariant wouldn't be clear (as we discussed offline) So all in all I believe the current approach is preferable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
