Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-204500365
Looks pretty good. I noticed three remaining things:
- Sometimes, the package and the directory trees are different (example:
`OnCoGroupDataSetTest.scala`). While Scala allows that, we usually keep them in
sync.
- The classes that implement the "withX" functions sometimes have context
bounds that I think they should not require (see inline comment above). Would
be great to remove them, because removing them later makes it API breaking.
- We need to decide how to label this for the future: stable, or
evolving. I would suggest to use `@PublicEvolving` on all the involved classes
for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
