xintongsong commented on a change in pull request #14966: URL: https://github.com/apache/flink/pull/14966#discussion_r579655822
########## File path: flink-core/src/main/java/org/apache/flink/core/memory/UnsafeMemorySegment.java ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.core.memory; + +import org.apache.flink.annotation.Internal; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; + +import java.nio.ByteBuffer; + +/** + * This class represents a piece of unsafe off-heap memory managed by Flink. + * + * <p>Note that memory segments should usually not be allocated manually, but rather through the + * {@link MemorySegmentFactory}. + */ +@Internal +public class UnsafeMemorySegment extends OffHeapMemorySegment { + @Nullable private final Runnable cleaner; + + /** + * Creates a new memory segment that represents the memory backing the given unsafe byte buffer. + * Note that the given ByteBuffer must be direct {@link + * java.nio.ByteBuffer#allocateDirect(int)}, otherwise this method with throw an + * IllegalArgumentException. + * + * <p>The memory segment references the given owner. + * + * @param buffer The byte buffer whose memory is represented by this memory segment. + * @param owner The owner references by this memory segment. + * @param cleaner The cleaner to be called on free segment. + * @throws IllegalArgumentException Thrown, if the given ByteBuffer is not direct. + */ + UnsafeMemorySegment( + @Nonnull ByteBuffer buffer, @Nullable Object owner, @Nullable Runnable cleaner) { Review comment: Nice catch. We should no longer have null cleaner. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
