XComp commented on a change in pull request #14804:
URL: https://github.com/apache/flink/pull/14804#discussion_r580067657
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerRunnerResult.java
##########
@@ -81,21 +83,23 @@ public boolean equals(Object o) {
return false;
}
JobManagerRunnerResult that = (JobManagerRunnerResult) o;
- return Objects.equals(archivedExecutionGraph,
that.archivedExecutionGraph)
+ // TODO: verify ExecutionGraphInfo.equals
+ return Objects.equals(executionGraphInfo, that.executionGraphInfo)
&& Objects.equals(failure, that.failure);
}
@Override
public int hashCode() {
- return Objects.hash(archivedExecutionGraph, failure);
+ // TODO: verify ExecutionGraphInfo.hashCode
Review comment:
See [related
discussion](https://github.com/apache/flink/pull/14804#discussion_r580067125)
for the corresponding `equals()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
