wangyang0918 commented on a change in pull request #14629:
URL: https://github.com/apache/flink/pull/14629#discussion_r581591845
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -339,6 +339,11 @@ public void close() {
this.internalClient.close();
}
+ @Override
+ public KubernetesPod loadPodFromTemplateFile(String file) {
+ return new KubernetesPod(this.internalClient.pods().load(file).get());
Review comment:
If the `file` is an invalid file path or the file format is not right,
the fabric8 Kubernetes client will fail with exception. Given that this is
uncertain assumption, I will move the existence check from
`KubernetesUtils#loadPodFromTemplateFile` to here.
The `load()#get()` will always return a non-null value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
