curcur commented on pull request #14943:
URL: https://github.com/apache/flink/pull/14943#issuecomment-788699250
@rkhachatryan Hey Roman, I believe I've addressed most of your comments
except two:
1. "Flag in API" we discussed yesterday
2. Introduce test interface for `numKeyValueStateEntries`
For 1. I was thinking about whether we can put the flag in API in JM-config
and TM-config; and initiate the wrapper loadStateBackend; the same place as:
`if (config.get(CheckpointingOptions.ENABLE_STATE_CHANGE_LOG)) {`
so `fromApplication` would still be kept as an unwrapped state bakcend.
====
You also mentioned that statebackend is loaded for recovery: do you mean
something here?
Checkpoints#loadCheckpointStorage
Checkpoints#loadStateBackendFromConfig
StateBackendLoader#loadStateBackendFromConfig
For 2, I am still feeling introduce a test interface for
`numKeyValueStateEntries` is a bit overkill...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
