[
https://issues.apache.org/jira/browse/FLINK-21482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy updated FLINK-21482:
-------------------------
Summary: Fix bug when use grouping set/rollup/cube syntax in Window TVF
(was: Support grouping set syntax for Window TVF based aggregation)
> Fix bug when use grouping set/rollup/cube syntax in Window TVF
> ---------------------------------------------------------------
>
> Key: FLINK-21482
> URL: https://issues.apache.org/jira/browse/FLINK-21482
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API, Table SQL / Planner
> Reporter: Andy
> Assignee: Andy
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> Now window tvf could work well like the following sql.
> {code:java}
> SELECT
> GROUPING_ID(`name`),
> `name`,
> window_start,
> window_end,
> COUNT(*),
> SUM(`bigdec`),
> MAX(`double`),
> MIN(`float`),
> COUNT(DISTINCT `string`),
> concat_distinct_agg(`string`)
> FROM TABLE(
> CUMULATE(
> TABLE T1,
> DESCRIPTOR(rowtime),
> INTERVAL '5' SECOND,
> INTERVAL '15' SECOND))
> GROUP BY GROUPING SETS((`name`),()), window_start, window_end{code}
>
> However, an exception would be thrown out when generate plan for the
> following sql. (We could not support this case, but we need a friendly tip
> for user.)
> {code:java}
> SELECT
> a,
> count(distinct c) AS uv
> FROM TABLE(TUMBLE(TABLE MyTable, DESCRIPTOR(rowtime), INTERVAL '15' MINUTE))
> GROUP BY GROUPING SETS ((a), (window_start), (window_end)){code}
> The exception like the following:
> {code:java}
> java.lang.AssertionError: Sql optimization: Assertion error: project filed
> count is not equal to output field count.java.lang.AssertionError: Sql
> optimization: Assertion error: project filed count is not equal to output
> field count.
> at
> org.apache.flink.table.planner.plan.optimize.program.FlinkVolcanoProgram.optimize(FlinkVolcanoProgram.scala:84)
> at
> org.apache.flink.table.planner.plan.optimize.program.FlinkChainedProgram$$anonfun$optimize$1.apply(FlinkChainedProgram.scala:62)
> at
> org.apache.flink.table.planner.plan.optimize.program.FlinkChainedProgram$$anonfun$optimize$1.apply(FlinkChainedProgram.scala:58)
> at
> scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)
> at
> scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)
> at scala.collection.Iterator$class.foreach(Iterator.scala:891) at
> scala.collection.AbstractIterator.foreach(Iterator.scala:1334) at
> scala.collection.IterableLike$class.foreach(IterableLike.scala:72) at
> scala.collection.AbstractIterable.foreach(Iterable.scala:54) at
> scala.collection.TraversableOnce$class.foldLeft(TraversableOnce.scala:157) at
> scala.collection.AbstractTraversable.foldLeft(Traversable.scala:104) at
> org.apache.flink.table.planner.plan.optimize.program.FlinkChainedProgram.optimize(FlinkChainedProgram.scala:57)
> at
> org.apache.flink.table.planner.plan.optimize.StreamCommonSubGraphBasedOptimizer.optimizeTree(StreamCommonSubGraphBasedOptimizer.scala:163)
> at
> org.apache.flink.table.planner.plan.optimize.StreamCommonSubGraphBasedOptimizer.doOptimize(StreamCommonSubGraphBasedOptimizer.scala:79)
> at
> org.apache.flink.table.planner.plan.optimize.CommonSubGraphBasedOptimizer.optimize(CommonSubGraphBasedOptimizer.scala:77)
> at
> org.apache.flink.table.planner.delegation.PlannerBase.optimize(PlannerBase.scala:288)
> at
> org.apache.flink.table.planner.utils.TableTestUtilBase.assertPlanEquals(TableTestBase.scala:860)
> at
> org.apache.flink.table.planner.utils.TableTestUtilBase.doVerifyPlan(TableTestBase.scala:751)
> at
> org.apache.flink.table.planner.utils.TableTestUtilBase.verifyRelPlan(TableTestBase.scala:398)
> at
> org.apache.flink.table.planner.plan.stream.sql.agg.WindowAggregateTest.testCantMergeWindowTVF_GroupingSetsWithoutWindowStartEnd(WindowAggregateTest.scala:696)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at
> org.junit.rules.RunRules.evaluate(RunRules.java:20) at
> org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at
> org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137) at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)Caused by:
> java.lang.AssertionError: project filed count is not equal to output field
> count. at org.apache.calcite.util.Litmus$1.fail(Litmus.java:31) at
> org.apache.flink.table.planner.plan.nodes.calcite.Expand.isValid(Expand.scala:63)
> at
> org.apache.flink.table.planner.plan.nodes.calcite.Expand.<init>(Expand.scala:56)
> at
> org.apache.flink.table.planner.plan.nodes.physical.stream.StreamPhysicalExpand.<init>(StreamPhysicalExpand.scala:42)
> at
> org.apache.flink.table.planner.plan.rules.physical.stream.ExpandWindowTableFunctionTransposeRule.buildNewExpand(ExpandWindowTableFunctionTransposeRule.scala:253)
> at
> org.apache.flink.table.planner.plan.rules.physical.stream.ExpandWindowTableFunctionTransposeRule.onMatch(ExpandWindowTableFunctionTransposeRule.scala:151)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:229)
> at
> org.apache.calcite.plan.volcano.IterativeRuleDriver.drive(IterativeRuleDriver.java:58)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:510)
> at org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:312)
> at
> org.apache.flink.table.planner.plan.optimize.program.FlinkVolcanoProgram.optimize(FlinkVolcanoProgram.scala:64)
> ... 45 more{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
