tillrohrmann commented on a change in pull request #15093:
URL: https://github.com/apache/flink/pull/15093#discussion_r588350564
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
##########
@@ -991,13 +1027,11 @@ public TestingJobManagerRunner createJobManagerRunner(
final BlockingJobVertex blockingJobVertex = new
BlockingJobVertex("testVertex");
blockingJobVertex.setInvokableClass(NoOpInvokable.class);
return Tuple2.of(
- new JobGraph(TEST_JOB_ID, "blockingTestJob",
blockingJobVertex), blockingJobVertex);
- }
-
- private JobGraph createFailingJobGraph(Exception failureCause) {
- final FailingJobVertex jobVertex = new FailingJobVertex("Failing
JobVertex", failureCause);
- jobVertex.setInvokableClass(NoOpInvokable.class);
- return new JobGraph(jobGraph.getJobID(), "Failing JobGraph",
jobVertex);
+ JobGraphBuilder.newStreamingJobGraphBuilder()
+ .setJobId(jobId)
+ .addJobVertex(blockingJobVertex)
+ .build(),
+ blockingJobVertex);
}
private static class FailingJobVertex extends JobVertex {
Review comment:
I also added a couple of tests which relied on scheduler details. I
think before we did not have the necessity to separate tests thoroughly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
