twalthr commented on a change in pull request #15098: URL: https://github.com/apache/flink/pull/15098#discussion_r590493784
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/DefaultCatalogTable.java ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.api.TableSchema; + +import javax.annotation.Nullable; + +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** Default implementation of a {@link CatalogTable}. */ +@Internal +class DefaultCatalogTable implements CatalogTable { + + private final Schema schema; + private final @Nullable String comment; + private final List<String> partitionKeys; + private final Map<String, String> options; + + DefaultCatalogTable( + Schema schema, + @Nullable String comment, + List<String> partitionKeys, + Map<String, String> options) { + this.schema = checkNotNull(schema, "Schema must not be null."); + this.comment = comment; + this.partitionKeys = checkNotNull(partitionKeys, "Partition keys must not be null."); + this.options = checkNotNull(options, "Options must not be null."); + + checkArgument( + options.entrySet().stream() + .allMatch(e -> e.getKey() != null && e.getValue() != null), + "Options cannot have null keys or values."); + } + + // TODO uncomment + // @Override + public Schema getUnresolvedSchema() { + return schema; + } + + @Override + public TableSchema getSchema() { + // TODO move to upper class + return null; + } + + @Override + public String getComment() { + return comment != null ? comment : ""; + } + + @Override + public boolean isPartitioned() { + return !partitionKeys.isEmpty(); + } + + @Override + public List<String> getPartitionKeys() { + return partitionKeys; + } + + @Override + public Map<String, String> getOptions() { + return options; + } + + @Override + public CatalogBaseTable copy() { + return this; + } + + @Override + public CatalogTable copy(Map<String, String> options) { Review comment: This copy method came later for dynamic table options using hints in SQL. Changing other things is not supported yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
