KarmaGYZ commented on a change in pull request #15128:
URL: https://github.com/apache/flink/pull/15128#discussion_r590980983
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorProcessSpec.java
##########
@@ -85,6 +85,8 @@
private final CPUResource cpuCores;
+ private final int numSlots;
Review comment:
We all also need to cover this field in `toString `.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/WorkerResourceSpec.java
##########
@@ -46,18 +46,22 @@
private final MemorySize managedMemSize;
+ private final int numSlots;
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
