[GitHub] [flink] zentol commented on a change in pull request #15105: [FLINK-21606] Reject JobManager <-> TaskManager connection if JobManager is not responsible for job

[GitBox]

zentol commented on a change in pull request #15105:
URL: https://github.com/apache/flink/pull/15105#discussion_r591396373



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/DefaultJobLeaderService.java
##########
@@ -470,6 +475,7 @@ protected void onRegistrationFailure(Throwable failure) {
             return gateway.registerTaskManager(
                     taskManagerRpcAddress,
                     unresolvedTaskManagerLocation,
+                    jobId,

Review comment:
       Why is it not more appropriate to use the fencingToken for this? It 
seems that the issue is less that we're connecting to the JM for another job, 
but that we don't connect to the JM we intended to?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org