zentol edited a comment on pull request #15105: URL: https://github.com/apache/flink/pull/15105#issuecomment-796637682
> [JobMasterId is 0 in non-HA case] What would speak against removing this special case? > [...] we have no way of exchanging the leader ids [in non-HA setups] For this particular issue we wouldn't really need that. `TaskExecutor#establishJobManagerConnection` already compares fencing tokens when re-establishing a connection which (I presume...) it retrieves from the RPC system; if we'd generate an actual JobMasterId in non-HA cases things should actually just work. Note that we still could exchange the JobMasterId in non-HA cases, because the RM has access to it when the JM registers itself or requests slots. We could forward that to `TaskExecutor#requestSlot`. I haven't dug deeper to answer "then what?"; but at least we can provide access to it pretty easily. (In HA cases this argument would likely be ignored) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
