gaoyunhaii commented on a change in pull request #14754: URL: https://github.com/apache/flink/pull/14754#discussion_r592967766
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/FullyFinishedOperatorState.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint; + +import org.apache.flink.runtime.jobgraph.OperatorID; + +/** + * A special operator state implementation representing the operators whose instances are all + * finished. + */ +public class FullyFinishedOperatorState extends OperatorState { Review comment: We should indeed need to override equals / hashcode so we could distinguish the finished operator and the empty operator state. I added these methods. Regarding coordinator state, currently I also do not have specific examples that keep coordinator state after all the operators are finished. For fully finished operators, we would directly skip their execution after failover, thus all its state should not take effect. Now I also disabled setting the coordinator state. Very thanks for pointing out these issues ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
