Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1862#discussion_r59181718
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/TranslationContext.scala
 ---
    @@ -53,21 +55,26 @@ object TranslationContext {
         // configure sql parser
         // we use Java lex because back ticks are easier than double quotes in 
programming
         // and cases are preserved
    -    val parserConfig = SqlParser.configBuilder().setLex(Lex.JAVA).build()
    +    val parserConfig = SqlParser
    +      .configBuilder()
    +      .setLex(Lex.JAVA)
    +      .build()
     
         // initialize RelBuilder
         frameworkConfig = Frameworks
           .newConfigBuilder
           .defaultSchema(tables)
           .parserConfig(parserConfig)
           .costFactory(new DataSetCostFactory)
    -      .traitDefs(ConventionTraitDef.INSTANCE)
    +      .programs(Programs.ofRules(FlinkRuleSets.DATASET_OPT_RULES))
    --- End diff --
    
    I think this line can be removed because we set the rules explicitly before 
calling the optimizer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to