lincoln-lil commented on a change in pull request #15117:
URL: https://github.com/apache/flink/pull/15117#discussion_r594210887
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdDistinctRowCount.scala
##########
@@ -223,7 +223,7 @@ class FlinkRelMdDistinctRowCount private extends
MetadataHandler[BuiltInMetadata
val groupKeyOfCurrentProject = new JArrayList[Int]()
groupKeySkipExpandId.foreach { key =>
project.get(key) match {
- case literal: RexLiteral if literal.isNull => // do nothing
+ case literal: RexLiteral if literal.isNull ||
literal.isAlwaysFalse => // do nothing
Review comment:
It's unnecessary now, just a patch for the boolean type literal which
introduced from the previous offline discussion.
I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
