zentol commented on a change in pull request #15159:
URL: https://github.com/apache/flink/pull/15159#discussion_r594806790
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -411,6 +411,35 @@
.text(
"Increasing this value will make
the cluster more resilient against temporary resources shortages (e.g., there
is more time for a failed TaskManager to be restarted), "
+ "while decreasing this
value reduces downtime of a job (provided that enough slots are available to
still run the job).")
+ .linebreak()
+ .text(
+ "Setting a negative duration will
disable the resource timeout: The JobManager will wait indefinitely for
resources to appear.")
+ .linebreak()
+ .text(
+ "If %s is configured to %s, this
configuration value will default to a negative value to disable the resource
timeout.",
+ code(SCHEDULER_MODE.key()),
+
code(SchedulerExecutionMode.REACTIVE.name()))
+ .build());
+
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Duration> RESOURCE_STABILIZATION_TIMEOUT =
+ key("jobmanager.adaptive-scheduler.resource-stabilization-timeout")
+ .durationType()
+ .defaultValue(RESOURCE_WAIT_TIMEOUT.defaultValue())
+ .withDescription(
+ Description.builder()
+ .text(
+ "The resource stabilization
timeout defines the time the JobManager will wait "
Review comment:
I found it quite difficult to grasp what exactly this option does, and
would suggest a re-phrasing:
`The time the JobManager will wait for to acquire further resources, once
the minimum set of resources required for the execution of a job has been
acquired. Once [...]`
Maybe also expand the documentation along the lines of (a lower value
results in the job starting up faster, while higher value ...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
