fsk119 commented on a change in pull request #15197:
URL: https://github.com/apache/flink/pull/15197#discussion_r594830451
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
##########
@@ -444,6 +444,7 @@ public void testStreamQueryExecutionSink() throws Exception
{
replaceVars.put("$VAR_SOURCE_SINK_PATH", csvOutputPath);
replaceVars.put("$VAR_UPDATE_MODE", "update-mode: append");
replaceVars.put("$VAR_MAX_ROWS", "100");
+ replaceVars.put("$VAR_RESULT_MODE", "table");
Review comment:
This test will create a `ResultDescriptor` that needs to read
`sql-client.execution.result-mode` from the configuration. Because the value
type of the option is enum and `$VAR_RESULT_MODE` doesn't belong to the enum.
In the origin code, it just reads from the `Envrionemnt` and compare the
type whether is equal to `tableau`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
