[ 
https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235376#comment-15235376
 ] 

ASF GitHub Bot commented on FLINK-2998:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1838#discussion_r59232837
  
    --- Diff: 
flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/JoinGlobalPropertiesCompatibilityTest.java
 ---
    @@ -35,7 +37,7 @@ public void checkCompatiblePartitionings() {
                        final FieldList keysLeft = new FieldList(1, 4);
                        final FieldList keysRight = new FieldList(3, 1);
     
    -                   SortMergeInnerJoinDescriptor descr = new 
SortMergeInnerJoinDescriptor(keysLeft, keysRight);
    +                   SortMergeInnerJoinDescriptor descr1 = new 
SortMergeInnerJoinDescriptor(keysLeft, keysRight);
    --- End diff --
    
    why do you rename this variable. I think it can be used for the new tests 
as well, no?


> Support range partition comparison for multi input nodes.
> ---------------------------------------------------------
>
>                 Key: FLINK-2998
>                 URL: https://issues.apache.org/jira/browse/FLINK-2998
>             Project: Flink
>          Issue Type: New Feature
>          Components: Optimizer
>            Reporter: Chengxiang Li
>            Priority: Minor
>
> The optimizer may have potential opportunity to optimize the DAG while it 
> found two input range partition are equivalent, we does not support the 
> comparison yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to