[
https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235390#comment-15235390
]
Yijie Shen commented on FLINK-3723:
-----------------------------------
??Or do you assume that these will be implicitly added because they are
grouping fields??
Yes, I do :)
I came across this issue while checking {{select}}'s implementation, I found
{{extractAggCalls}} is doing a complex job there and haven't found check for
nondeterministic fields yet(where does the check really happens?). So I thought
validation will be much easier if we create an {{agg}} here, and easier to use
as well.
> Aggregate Functions and scalar expressions shouldn't be mixed in select
> -----------------------------------------------------------------------
>
> Key: FLINK-3723
> URL: https://issues.apache.org/jira/browse/FLINK-3723
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Affects Versions: 1.0.1
> Reporter: Yijie Shen
>
> When we type {code}select deptno, name, max(age) from dept group by
> deptno;{code} in calcite or Oracle, it will complain {code}Expression 'NAME'
> is not being grouped{code} or {code}Column 'dept.name' is invalid in the
> select list because it is not contained in either an aggregate function or
> the GROUP BY clause.{code} because of the nondeterministic result.
> Therefore, I suggest to separate the current functionality of `select` into
> two api, the new `select` only handle scalar expressions, and an `agg` accept
> Aggregates.
> {code}
> def select(exprs: Expression*)
> def agg(aggs: Aggregation*)
> ....
> tbl.groupBy('deptno)
> .agg('age.max, 'age.min)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
