[
https://issues.apache.org/jira/browse/FLINK-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235608#comment-15235608
]
ASF GitHub Bot commented on FLINK-3731:
---------------------------------------
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1869
[FLINK-3731] make embedded SQL outer joins fail during translation
The `DataSetJoinRule` only matches for inner joins. Outer joins will throw
a `PlanGenException`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vasia/flink outer-join-fail
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1869
----
commit b8c5fe35b5ea08ac82aaf739f0e36842ca972dbc
Author: vasia <[email protected]>
Date: 2016-04-11T17:43:59Z
[FLINK-3731] make embedded SQL outer joins fail during translation
----
> Embedded SQL outer joins should fail during translation
> -------------------------------------------------------
>
> Key: FLINK-3731
> URL: https://issues.apache.org/jira/browse/FLINK-3731
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> The {{DataSetJoinRule}} sets the join type to {{JoinType.INNER}}, meaning
> that outer joins are incorrectly translated to inner joins. The match method
> of the rule should check the join type and fail to produce a valid plan if
> it's not an inner join.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
