[GitHub] [flink] JingsongLi commented on a change in pull request #15236: [FLINK-21818][table] Refactor SlicingWindowAggOperatorBuilder to accept serializer instead of LogicalType

[GitBox]

JingsongLi commented on a change in pull request #15236:
URL: https://github.com/apache/flink/pull/15236#discussion_r595686332



##########
File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/combines/CombineRecordsFunction.java
##########
@@ -59,8 +57,11 @@
     /** Whether to copy key and input record, because key and record are 
reused. */
     private final boolean requiresCopy;
 
+    /** Serializer to copy key if required. */
+    private AbstractRowDataSerializer<RowData> keySerializer;

Review comment:
       👍 Now types are:
   ```
       private AbstractRowDataSerializer<RowData> inputSerializer; // Need 
toBinaryRow
       private PagedTypeSerializer<RowData> keySerializer; // Need 
PagedTypeSerializer in BytesHashMap
       private TypeSerializer<RowData> accSerializer;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org