GitHub user yjshen opened a pull request:
https://github.com/apache/flink/pull/1870
[FLINK-3736][TableAPI]Move toRexNode & toAggCall logic into each
expression's implementation
Since we have a one-to-one mapping from Flink `Expression` to Calcite
`RexNode`, I think it's a good practice to make `toRexNode` a behaviour of each
Expression.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yjshen/flink toRexNode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1870.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1870
----
commit 32085a3f559a9d5510a85de01c63a23ce5497535
Author: Yijie Shen <[email protected]>
Date: 2016-04-11T17:33:15Z
move toRexNode logic into each expression's implementation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
