[
https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235910#comment-15235910
]
ASF GitHub Bot commented on FLINK-3736:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1870#issuecomment-208542966
Hi @yjshen, thanks for the PR! I agree, moving the `RexNode` translation to
the individual `Expression` makes a lot of sense. I only skimmed the PR and did
not have a detailed look but everything looks fine.
Will check the PR more thoroughly tomorrow and probably merge it.
> Move toRexNode and toAggCall logic into Expressions
> ---------------------------------------------------
>
> Key: FLINK-3736
> URL: https://issues.apache.org/jira/browse/FLINK-3736
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Reporter: Yijie Shen
> Priority: Minor
>
> Since we have a one-to-one mapping from Flink {{Expression}} to Calcite
> {{RexNode}}, and we will implement more and more expressions to make
> flink-table a full-fledged module, I think it's worthwhile to let each
> {{Expression}} take care of its own behaviour on conversion to {{RexNode}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
