[
https://issues.apache.org/jira/browse/FLINK-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237808#comment-15237808
]
ASF GitHub Bot commented on FLINK-3732:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1871#issuecomment-209062546
Code looks good, but it triggers a checkstyle violation: indentation
includes a space.
Please have a look at the Travis CI logs...
> Potential null deference in ExecutionConfig#equals()
> ----------------------------------------------------
>
> Key: FLINK-3732
> URL: https://issues.apache.org/jira/browse/FLINK-3732
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> ((restartStrategyConfiguration == null &&
> other.restartStrategyConfiguration == null) ||
>
> restartStrategyConfiguration.equals(other.restartStrategyConfiguration)) &&
> {code}
> If restartStrategyConfiguration is null but
> other.restartStrategyConfiguration is not null, the above would result in NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
