[GitHub] [flink] fsk119 commented on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

Sun, 21 Mar 2021 19:23:57 -0700 


fsk119 commented on pull request #15282:
URL: https://github.com/apache/flink/pull/15282#issuecomment-803718841


   Thanks for your contribution @SteNicholas.
   
   I have some thoughts about this PR. Because our goal is to submit statement 
set in the sql client. However,  the `Executor` is just a wrapper of the 
`TableEnvironment` that can notice the `Operation` rather than `SqlNode`.  
Therefore, we need to introduce operations.
   
   The second question is how sql client submits statement. In the FLIP, we 
reach consensus that the desired behaviour looks like
   ```
   Flink SQL> BEGIN STATEMENT SET;
    
   [Info] Begin the statement set.
    
   Flink SQL> INSERT INTO emps1 SELECT * FROM emps(x, y);
    
   [Info] Add the statement into the statement set.
    
   Flink SQL> INSERT INTO emps2 SELECT * FROM emps(x, y);
    
   [Info] Add the statement into the statement set.
    
   Flink SQL> END;
    
   [Info] Submitting SQL statement set to the cluster...
   
   ```
   
   I think the proposed grammer may not achieve the final goal.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to